Skip to content

[Backport 1.x] Setup extension TLS#718

Merged
saratvemulapalli merged 3 commits intoopensearch-project:1.xfrom
cwperks:backport/backport-619-to-1.x
May 2, 2023
Merged

[Backport 1.x] Setup extension TLS#718
saratvemulapalli merged 3 commits intoopensearch-project:1.xfrom
cwperks:backport/backport-619-to-1.x

Conversation

@cwperks
Copy link
Member

@cwperks cwperks commented May 1, 2023

Backport of #619 to 1.x

* WIP on Handler naming and SSL

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Add concept of extension shortname via settings

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* WIP on extension ssl

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Get registry from runner

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Read settings from extension config file

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Update license headers

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Run spotlessApply

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Remove authz changes and only keep TLS

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Remove authz changes and only keep TLS

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Remove authz changes and only keep TLS

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Remove authz changes and only keep TLS

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Remove authz changes and only keep TLS

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Update cert generation documents

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Add ssl.transport.enabled in ExtensionsRunner

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Merge main into branch

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Add instructions for running in SSL only mode

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Add all SSL settings to extension settings

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Set default enforce_hostname_verification

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Run spotlessApply

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Respond to code review feedback

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Fix typos in debug messages

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Add docstrings

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Address code review feedback

Signed-off-by: Craig Perkins <cwperx@amazon.com>

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
(cherry picked from commit b13f257)
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Copy link
Member Author

cwperks commented May 1, 2023

@saratvemulapalli Can you backport opensearch-project/OpenSearch#6866 to 2.x?

@owaiskazi19
Copy link
Member

@saratvemulapalli Can you backport opensearch-project/OpenSearch#6866 to 2.x?

@cwperks I added the backport label but it failed. Looks like you have to raise a manual backport PR on core as well.

@cwperks
Copy link
Member Author

cwperks commented May 1, 2023

Thank you @owaiskazi19 , here's the backport in core: opensearch-project/OpenSearch#7346

@codecov-commenter
Copy link

Codecov Report

Merging #718 (04ed323) into 1.x (fd74041) will decrease coverage by 23.40%.
The diff coverage is 2.91%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@              Coverage Diff              @@
##                1.x     #718       +/-   ##
=============================================
- Coverage     66.04%   42.65%   -23.40%     
- Complexity      301      306        +5     
=============================================
  Files            55       69       +14     
  Lines          1237     1953      +716     
  Branches         41      137       +96     
=============================================
+ Hits            817      833       +16     
- Misses          408     1104      +696     
- Partials         12       16        +4     
Impacted Files Coverage Δ
...ava/org/opensearch/sdk/ssl/DefaultSslKeyStore.java 0.00% <0.00%> (ø)
...ava/org/opensearch/sdk/ssl/SSLConfigConstants.java 0.00% <0.00%> (ø)
...rg/opensearch/sdk/ssl/SSLConnectionTestResult.java 0.00% <0.00%> (ø)
...java/org/opensearch/sdk/ssl/SSLNettyTransport.java 0.00% <0.00%> (ø)
...java/org/opensearch/sdk/ssl/SecureSSLSettings.java 0.00% <0.00%> (ø)
...ava/org/opensearch/sdk/ssl/util/CertFileProps.java 0.00% <0.00%> (ø)
...java/org/opensearch/sdk/ssl/util/CertFromFile.java 0.00% <0.00%> (ø)
.../org/opensearch/sdk/ssl/util/CertFromKeystore.java 0.00% <0.00%> (ø)
...rg/opensearch/sdk/ssl/util/CertFromTruststore.java 0.00% <0.00%> (ø)
...va/org/opensearch/sdk/ssl/util/ExceptionUtils.java 0.00% <0.00%> (ø)
... and 8 more

@saratvemulapalli saratvemulapalli merged commit 516f495 into opensearch-project:1.x May 2, 2023
caokyhieu pushed a commit to caokyhieu/opensearch-sdk-java that referenced this pull request Aug 15, 2025
* Setup extension TLS (opensearch-project#619)

* WIP on Handler naming and SSL

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Add concept of extension shortname via settings

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* WIP on extension ssl

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Get registry from runner

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Read settings from extension config file

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Update license headers

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Run spotlessApply

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Remove authz changes and only keep TLS

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Remove authz changes and only keep TLS

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Remove authz changes and only keep TLS

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Remove authz changes and only keep TLS

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Remove authz changes and only keep TLS

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Update cert generation documents

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Add ssl.transport.enabled in ExtensionsRunner

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Merge main into branch

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Add instructions for running in SSL only mode

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Add all SSL settings to extension settings

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Set default enforce_hostname_verification

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Run spotlessApply

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Respond to code review feedback

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Fix typos in debug messages

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Add docstrings

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Address code review feedback

Signed-off-by: Craig Perkins <cwperx@amazon.com>

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
(cherry picked from commit b13f257)

* Switch configDir to configFile

Signed-off-by: Craig Perkins <cwperx@amazon.com>

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Co-authored-by: Owais Kazi <owaiskazi19@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants